build(broccoli): store DiffResult for re-use only if DiffResult #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed 1 of 1 files at r3. Comments from the review on Reviewable.io |
mhevery
added
pr_state: LGTM
action: merge
|
Please rebase to latest master |
|
done, |
caitp
force-pushed
the
issue-2662
branch
2 times, most recently
from
0949fbe
to
c18eb92
Compare
This reverts commit 2c3c235.
One of the non-angular broccoli plugins returns a weird object. We can't assume that all trees meet the contract that we expect them to meet, so we do a typecheck before storing the result of the rebuild. Closes angular#2662
Doing this would break trees which are used multiple times.
|
Landed in master as 73b3ed1 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the non-angular broccoli plugins returns a weird object. We can't
assume that all trees meet the contract that we expect them to meet, so
we do a typecheck before storing the result of the rebuild.
Closes #2662